Question

我有一份小篇文字,界定了一个称为<代码>的变量。这份文字并非按我的意图行事,因为某些部法的产品显示与其他部门法典有关的价格。因此,我假定,我最初把这一点放在一起的方式有些错。

我要问的是,谁会发现一个问题,或提出如何改进以下简明的网址:

// Cost plus 2.5%
if ($prDept = (204 || 205 || 209 || 1501 || 1601 )) {
    if ($_SESSION[ tax ] == "on" || !isset($_SESSION[ tax ]))
        $prPrice = ((($prCost1 / 1.14) * 1.025) * 1.14);
    else if ($_SESSION[ tax ] == "off" && $prTaxable == "1")
        $prPrice = ($prCost1 * 1.025);
    else if ($_SESSION[ tax ] == "off" && $prTaxable == "0")
        $prPrice = (($prCost1 / 1.14) * 1.025);

iii

Answer 1

$prDept = (204 || 205 || 209 || 1501 || 1601)

这并不是购买力平价中的这种工作。确实需要看好......

$prDept == 204 || $prDept == 205 || $prDept == 209 || $prDept == 1501 || $prDept == 1601

或替代

in_array($prDept, array(204, 205, 209, 1501, 1601))

Answer 2

if ($prDept == 204 || $prDept == 205 || $prDept == 209 || $prDept == 1501 || $prDept == 1601) {
    if ($_SESSION[ tax ] == "on" || !isset($_SESSION[ tax ])) {
          $prPrice = ((($prCost1 / 1.14) * 1.025) * 1.14);
    } else if ($_SESSION[ tax ] == "off" && $prTaxable == "1") {
          $prPrice = ($prCost1 * 1.025);
    } else if ($_SESSION[ tax ] == "off" && $prTaxable == "0") {
          $prPrice = (($prCost1 / 1.14) * 1.025);
    }   
}

Answer 3

I would write this as:

$departments = array(204 , 205 , 209 ,1501, 1601);

if (in_array($prDept, $departments)) {
 ...
}

友情链接