Question

我是新鲜的,这样说,我不知道多少。我有以下内容,我想使其更加简单。任何建议都会受到赞赏。

if (entity == "house") {
    primaryKey = store.getItem( accountID ) + "02" + "00";
    table = "Content";
}
if (entity == "street") {
    primaryKey = store.getItem( accountID ) + "0000";
    table = "Content";
}
if (entity == "city") {
    var primaryKey = store.getItem( categoryID );
    table = "Reference";
}
if (entity == "location") {
    primaryKey = "0001" + store.getItem( examID );
    table = "Content";
}

Answer 1

你们可以采取由桌上驱动的做法,不重复成像:

var lookupInfo = {
    house: {id: "accountID", prefix, "", suffix: "0200", table: "Content"},
    street: {id: "accountID", prefix: "", suffix: "0000", table: "Content"},
    city: {id: "categoryID", prefix: "", suffix: "", table: "Reference"},
    location: {id: "examID", prefix: "0001", suffix: "", table: "Content"}
};

var primaryKey, data = lookupInfo[entity];
if (data) {
    primaryKey = data.prefix + store.getItem(data.id) + data.suffix;
    table = data.table;
}

除了尽量减少守则,不重复任何守则之外,还很容易在表格中增加更多的选择,而不必编写任何补充守则。

或者,数据表可以稍加紧凑,但并非像代表(从纯粹的方案拟订观点来看,由于编码硬数不变)。

var lookupInfo = {
    house: ["accountID", "", "0200", "Content"],
    street: ["accountID", "", "0000", "Content"],
    city: ["categoryID", "", "", "Reference"],
    location: ["examID", "0001", "", "Content"]
};

var primaryKey, data = lookupInfo[entity];
if (data) {
    primaryKey = data[1] + store.getItem(data[0]) + data[2];
    table = data[3];
}

无论是哪种方式,你们都想利用实体的考察表,然后就每个实体的不同价值采取表格驱动的办法。

Answer 2

You can use a switch statement. https://developer.mozilla.org/en/JavaScript/Reference/Statements/switch

var primaryKey;
var table = "Content";
switch (entity) {
    case "house":
        primaryKey = store.getItem( accountID ) + "0200";
        break;
    case "street":
        primaryKey = store.getItem( accountID ) + "0000";
        break;
    case "city":
        primaryKey = store.getItem( categoryID );
        table = "Reference";
        break;
    case "location":
        primaryKey = "0001" + store.getItem( examID );
        break;
    default:
        // do nothing
}

这仍然ver,但更容易阅读。

友情链接