Question

i 具有这一变量。

$productId = 2; // Testing ID
$value->id; // Contains INT
$value->datePurchaseEnd; // Contains UNIXTIME or NULL

The conditional i want to make. if ($value->id == $productId) return true;

但是,如果$->datePurchaseEnd; is notNUL,则该编码与目前时间比较,必须大于现在的返回代码<>。 TRUE

目前,这部法律是:

if( $value->id == $productId){
        if( $value->datePurchaseEnd == NULL ){
            $return = TRUE; break;
        }else{
            if( $value->datePurchaseEnd > mktime() ){
                $return = TRUE; break;
            }
        }
    }

But i feel this code is not good.
Is there any suggestion to make better code with conditional above?

Answer 1

我要说的是

if( ($value->id == $productId) && ($value->datePurchaseEnd == NULL || $value->datePurchaseEnd > mktime() )) {
        $return = true;
        break;
}

或

if($value->id == $productId) {
    if($value->datePurchaseEnd == NULL || $value->datePurchaseEnd > mktime()) {
        $return = true;
        break;
    }
}

取决于条件需要<代码>。

Answer 2

if( $value->id == $productId){
    $return = ($value->datePurchaseEnd == NULL || $value->datePurchaseEnd > mktime());
    break;
}

或

 $return = $value->id == $productId && ($value->datePurchaseEnd == NULL || $value->datePurchaseEnd > mktime());
 break;

Answer 3

如果贵国的法典不成漏洞,我更倾向于在线条件:

return $value->id == $productId && ($value->datePurchaseEnd == null || $value->datePurchaseEnd > mktime())

友情链接