Question

Say I have a function with a flag 或 something:

void foo (Param p1, Param p2, bool setVariable)
{
    //if setVariable is true, set some bool var to true, else false
}

是否有强烈的优待?

if (setVariable)
    _someClassVariable = true;
else
    _someClassVariable = false;

或

_someClassVariable = setVariable;

Obviously the second is less typing, but the first strikes me as m或e readable. Which one would be preferred?

Answer 1

我一般倾向于第二种。对我来说,首先强烈警告说,无论谁写这部法典,谁都完全有能力。

尽管如此,我也倾向于建议不要将ool作为准参数。它很少立即表明:<代码>foo(true); vsfoo(false); really means。通常最好使用一个清单,以便你获得<代码>foo(do_this); vsfoo(do_ that);。

Answer 2

I would go for the second, it is just as readable. Readability is more on the names of the variables than on the choice of both options. If the variables and parameters have good names the assignment will be natural. This is similar to returning a boolean from a function you would not do:

bool conditionHolds() {
    if (condition)
       return true;
    else
       return false;
}

(如果你正在考虑这样做,请重新思考)

Answer 3

我倾向于第二种。如果打字不好,那么你就有足够的论据,也考虑你们的同事的意见。如果我看到像我这样一些东西,我个人会感到 la笑。

if (condition)
   return true;
else
   return false;

in production code. (provided the variables are bool, and you re not using this to implement some casting mechanism).

Answer 4

后者更为可取,如果仅仅看看不使用,则在守则和汇编者编造的代码(尽管PROBABLY选择不适用)。

I would also avoid the leading underscore notation, some of those name are reserved fro the standard library and compiler.

友情链接