Question

我得到的Sql命令没有适当结束当击中下面的这条线。

stmt = conn.createStatement(ResultSet.TYPE_SCROLL_SENSITIVE,ResultSet.CONCUR_READ_ONLY);    
String updateQ = "update ANI_999 set First_Name =  "+d.getName()+" , HouseNo =  "+d.getAddr1()+" , Indicator_Sourcefile_iCARE3 = Indicator_Sourcefile_iCARE2, Indicator_Sourcefile_iCARE2 = Indicator_Sourcefile_iCARE1, Indicator_Sourcefile_iCARE1= "+currentFile+"  where CALLER_ID =  "+msisdn+"  ";

int result = stmt.executeUpdate(updateQ);
conn.commit();
conn.close();`

我不断得到ORA-00933: SQL指令没有适当结束。

update/code> 语句看起来像:



update ANI_999 set First_Name =  ZAHARAH BINTI ABDUL RAHMAN , HouseNo =  No. JKR6357, , Indicator_Sourcefile_iCARE3 = Indicator_Sourcefile_iCARE2, Indicator_Sourcefile_iCARE2 = Indicator_Sourcefile_iCARE1, Indicator_Sourcefile_iCARE1= ICAREP_ANI_SVCPROF_20120402_002.DAT  where CALLER_ID =  058011726  


这里就是整个函数: - 请将此符号“ & lt; & lt;” 命名为“ & lt; & lt;” 。

public void updateRecord(icData d, String msisdn) {
   Connection conn = null;
   Statement stmt = null;
   int recCtr = 0;

try {
   conn = ds.getConnection();

       stmt = conn.createStatement(ResultSet.TYPE_SCROLL_SENSITIVE,ResultSet.CONCUR_READ_ONLY); 
       String updateQ = "update ANI_999 set First_Name =  "+d.getName()+" , HouseNo =  "+d.getAddr1()+" , Indicator_Sourcefile_iCARE3 = Indicator_Sourcefile_iCARE2, Indicator_Sourcefile_iCARE2 = Indicator_Sourcefile_iCARE1, Indicator_Sourcefile_iCARE1= "+currentFile+"  where CALLER_ID =  "+msisdn+"  ";


   int result = stmt.executeUpdate(updateQ);
   conn.commit();
   conn.close();
}
catch(SQLException ex) {

    logger.error("iCARE:Error : " + ex.getMessage()); <<this line show me that error>>

}
finally {
    try {if (stmt != null) stmt.close();} catch (SQLException e) {}
        try {if (conn != null) conn.close();} catch (SQLException e) {}
}
}

Answer 1

您应该使用写作声明 :

String updateQ = "update ANI_999 set First_Name = ?, HouseNo = ?, " +
       "Indicator_Sourcefile_iCARE3 = Indicator_Sourcefile_iCARE2, " +
       "Indicator_Sourcefile_iCARE2 = Indicator_Sourcefile_iCARE1, " +
       "Indicator_Sourcefile_iCARE1=? where CALLER_ID = ? ";
PreparedStatement prep =  conn.prepareStatement(updateQ, 
    ResultSet.TYPE_SCROLL_SENSITIVE,ResultSet.CONCUR_READ_ONLY); 
prep.setString(1, ...);
prep.setString(2, ...);
prep.setString(3, ...);
int result = prep.executeUpdate(updateQ);

Answer 2

ERROR: ORA-00933: SQL command not properly ended.
CAUSE: You tried to execute an SQL statement with an inappropriate clause.

与其只是抓取错误信息,不如在抓取区块中抓取堆叠跟踪。这为您提供了有根源的语句执行的行号。

变动变动

logger.error("iCARE:Error : " + ex.getMessage()); // <<this line show me that error>>

将 to

ex.printStackTrace(); // <<this line show me that error>>

或者,你可以尝试以下的代码修改,看看它是否适合你。

您更新语句的输入中有可能有一些未隐藏的字符, 从而导致错误。将您的 < code> statement 对象更改为 < code> prepared statement , 看看是否解决。

try {  
  ...
  String updateQ = "update ANI_999"  
    + " set First_Name = ?, HouseNo = ?,"  
    + " Indicator_Sourcefile_iCARE3 = Indicator_Sourcefile_iCARE2,"  
    + " Indicator_Sourcefile_iCARE2 = Indicator_Sourcefile_iCARE1,"  
    + " Indicator_Sourcefile_iCARE1=?"   
    + " where CALLER_ID = ?";  

  PreparedStatement pstmt = conn
   .createStatement( updateQ, ResultSet.TYPE_SCROLL_SENSITIVE, ResultSet.CONCUR_READ_ONLY );  
  pstmt.setString( 1, d.getName() );  
  pstmt.setString( 2, d.getAddr1() );  
  pstmt.setString( 3, currentFile );  
  pstmt.setString( 4, msisdn );  

  // print what the query actually holds. Not sure if all drivers support this.
  System.out.println( "DEBUG: query: " + pstmt.toString() );

  int result = pstmt.executeUpdate( updateQ );  
  System.out.println( "DEBUG: Update Result: " + result );
  ...  
} catch ( Exception ex ) {  
  // logger.error( ...  
  ex.printStackTrace(); // keep this until debugged  
}  
...

Answer 3

如果您正在将变量字符串插入命令字符串,例如。

string inputName = "Rose";
string sqlCmd = "SELECT * FROM mytable WHERE brand_name =  " + inputName +" ";

(a) 以上所述工作正常,但如:

string inputName = "Rose s";

The resulting SQL is SELECT * FROM mytable WHERE brand_name = Rose s which throws ORA-00933, so remember to escape your single quotes!

如果你使用 LIKE 条款,那么你可能不得不开始考虑逃离 s。人们建议使用预先准备的语句的原因之一是,这样你就不必担心逃避。

友情链接