English 中文(简体)
Sending email updates: model or observer?
原标题:

I have an Event model, which stores an event feed for each user. I also need to email the updates to users which have enabled email notifications in their profile.

From an architectural point of view, which one is better?

  1. call the mailer in an after_create method in the model, since it s a part of the business logic;
  2. call the mailer in an after_create method in an observer, since it doesn t really operate on the model and it also depends on the user s settings.
最佳回答

I d go with an observer. My reason for this is that sending a notification email isn t an essential part of the business logic of an event (put simply, events don t send notifications). Other than that, as Damien has already said, it s a matter of separation of concerns.

Please, see the discussion here, as well.

问题回答

There s no "magic" answer to that as it s subjective.
Some developers will prefer to do that directly in the model. Others will do it in an observer.
What you do is completely up to you. Both solutions are valid.

I personnaly prefer to add them in an observer as it allows me to have all the user notifications in the same place and not one in one model and an other in an other model.

The observer approach will be more flexible. If your email setting (addressee or server) changes, or the criteria for notification (daily to weekly or vice versa), it is a simpler matter to change the observer than it is to modify the model.





相关问题
rails collection_select vs. select

collection_select and select Rails helpers: Which one should I use? I can t see a difference in both ways. Both helpers take a collection and generates options tags inside a select tag. Is there a ...

SSL slowness in EC2

We ve deployed our rails app to EC2. In our setup, we have two proxies on small instances behind round-robin DNS. These run nginx load balancers for a dynamically growing and shrinking farm of web ...

Auth-code with A-Za-z0-9 to use in an URL parameter

As part of a web application I need an auth-code to pass as a URL parameter. I am currently using (in Rails) : Digest::SHA1.hexdigest((object_id + rand(255)).to_s) Which provides long strings like : ...

RubyCAS-Client question: Rails

I ve installed RubyCAS-Client version 2.1.0 as a plugin within a rails app. It s working, but I d like to remove the ?ticket= in the url. Is this possible?

activerecord has_many :through find with one sql call

I have a these 3 models: class User < ActiveRecord::Base has_many :permissions, :dependent => :destroy has_many :roles, :through => :permissions end class Permission < ActiveRecord::...

Ordering a hash to xml: Rails

I m building an xml document from a hash. The xml attributes need to be in order. How can this be accomplished? hash.to_xml

Text Editor for Ruby-on-Rails

guys which text editor is good for Rubyonrails? i m using Windows and i was using E-Texteditor but its not free n its expired now can anyone plese tell me any free texteditor? n which one is best an ...

How to get SQL queries for each user where env is production

I’m developing an application dedicated to generate statistical reports, I would like that user after saving their stat report they save sql queries too. To do that I wrote the following module: ...

热门标签