Question

我有两种方法:

BuildThing(Thing a);
BuildThings(IEnumerable<Thing> things);

Is this good from a clean code point of view? Or is maybe it would be better to just use BuildThings and pass IEnumerable with only one Thing? Or use params?

感谢。

Answer 1

我的个人倾向如下:

接口:

void Build(Thing thing);
void Build(IEnumerable<Thing> things);

执行:

void Build(Thing thing)
{
    Build(new [] { thing });
}

void Build(IEnumerable<Thing> things)
{
    //do stuff
}

我倾向于采用这一模式的原因是,它确保你留在DRY 。虽然允许你灵活多载荷,但与<条码>第不同,你必须把任何非记录电子数字转换成一个阵列。

Answer 2

你们可以做的是:

BuildThings(params Thing[] things);

能够使用:

BuildThings(thing1, thing2, thing3, ...);

Answer 3

贵方的方法不会是好的解决方案。

i 认为,只要你只是一个执行方法,你就会有两条或更多方法。

public void BuildThing(Thing a)
{
    this.BuildThings(new List<Thing>(){a});
}

Answer 4

你提供的方法似乎是一种良好做法。当你只重新建立单一案例而不是多起案件时,你想要做的事情可能有所不同。

我不想使用<代码>第<>条/代码”,因为如果你有名单,就迫使你建立阵列。

Answer 5

Purely from a clean code point of view, this is perfectly ok. Although functionally the alternatives might or might not suit you better. For example, using params forces the collection to be enumerated before the call as opposed to lazily enumerated inside the call.

Answer 6

I would consider two cases:

to have those two methods, but in BuildThing(Thing a) I would use BuildThings(IEnumerable<Thing> things) and pass IEnumerable with only one Thing
Create only one method with params This option have one drawback - you have to convert every IEnumerable to Array (except of arrays of course) if you want to pass more then one argument.

I would go with params solution probably.

友情链接